ipc: Add ParamTraits<signed char>

ipc/ipc_message_utils.h

Index: ipc/ipc_message_utils.h
diff --git a/ipc/ipc_message_utils.h b/ipc/ipc_message_utils.h
index 45f424d763370538b95ac25c01c4bf24114cfc76..a08fcf23268561d4a528466853db81ef7d0751d7 100644
--- a/ipc/ipc_message_utils.h
+++ b/ipc/ipc_message_utils.h
@@ -141,6 +141,14 @@ struct IPC_EXPORT ParamTraits<unsigned char> {
 };
 
 template <>

[Tom Sepez, 2015/10/29 22:30:01]

nit: put this before <unsigned char> just to keep ordering the same as with the
other types (like int and long) below.

[ortuno, 2015/10/29 22:43:34]

Done.

+struct IPC_EXPORT ParamTraits<signed char> {

[Tom Sepez, 2015/10/29 22:30:01]

you shouldn't have to explicitly say "signed" -- I don't think there are
platforms we support where the "ambiguous signedness of char" loophole in the C
spec is actually used.

[ortuno, 2015/10/29 22:43:34]

If I don't put the 'signed' the compiler complains when trying to send a int8_t:

../../ipc/ipc_message_utils.h:116:22: error: no member named 'Log' in
'IPC::ParamTraits<signed char>'

+  typedef signed char param_type;
+  static void Write(Message* m, const param_type& p);
+  static bool Read(const Message* m, base::PickleIterator* iter, param_type* r);
+  static void Log(const param_type& p, std::string* l);
+};
+
+template <>
 struct IPC_EXPORT ParamTraits<unsigned short> {
   typedef unsigned short param_type;
   static void Write(Message* m, const param_type& p);