ipc: Add ParamTraits<signed char>

ipc/ipc_message_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_MESSAGE_UTILS_H_
 #define IPC_IPC_MESSAGE_UTILS_H_
 
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 122 matching lines @@
 };
 
 template <>
 struct IPC_EXPORT ParamTraits<unsigned char> {
   typedef unsigned char param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m, base::PickleIterator* iter, param_type* r);
   static void Log(const param_type& p, std::string* l);
 };
 
 template <>

[Tom Sepez, 2015/10/29 22:30:01]

nit: put this before <unsigned char> just to keep ordering the same as with the
other types (like int and long) below.

[ortuno, 2015/10/29 22:43:34]

Done.

+struct IPC_EXPORT ParamTraits<signed char> {

[Tom Sepez, 2015/10/29 22:30:01]

you shouldn't have to explicitly say "signed" -- I don't think there are
platforms we support where the "ambiguous signedness of char" loophole in the C
spec is actually used.

[ortuno, 2015/10/29 22:43:34]

If I don't put the 'signed' the compiler complains when trying to send a int8_t:

../../ipc/ipc_message_utils.h:116:22: error: no member named 'Log' in
'IPC::ParamTraits<signed char>'

+  typedef signed char param_type;
+  static void Write(Message* m, const param_type& p);
+  static bool Read(const Message* m, base::PickleIterator* iter, param_type* r);
+  static void Log(const param_type& p, std::string* l);
+};
+
+template <>
 struct IPC_EXPORT ParamTraits<unsigned short> {
   typedef unsigned short param_type;
   static void Write(Message* m, const param_type& p);
   static bool Read(const Message* m,
                    base::PickleIterator* iter,
                    param_type* r);
   static void Log(const param_type& p, std::string* l);
 };
 
 template <>
@@ skipping 904 matching lines @@
   template <typename... Ts>
   static void WriteReplyParams(Message* reply, Ts... args) {
     ReplyParam p(args...);
     WriteParam(reply, p);
   }
 };
 
 }  // namespace IPC
 
 #endif  // IPC_IPC_MESSAGE_UTILS_H_