ipc: Add ParamTraits<signed char>

ipc: Add ParamTraits<signed char>

To be used by BluetoothDispatcherHost in: http://crrev.com/1317933003

BUG=549327
Committed: https://crrev.com/19ecf184812568b0909e87fe903f2e7a62156322
Cr-Commit-Position: refs/heads/master@{#357001}

[ortuno, 2015-10-29 22:10:33]

ortuno@chromium.org changed reviewers:
+ tsepez@chromium.org

[ortuno, 2015-10-29 22:10:34]

tsepez: PTAL

[Tom Sepez, 2015-10-29 22:30:01]

Also ping mbarbella@ so he can fold this into the fuzzers.

https://codereview.chromium.org/1418743006/diff/1/ipc/ipc_message_utils.h
File ipc/ipc_message_utils.h (right):

https://codereview.chromium.org/1418743006/diff/1/ipc/ipc_message_utils.h#new...
ipc/ipc_message_utils.h:143: template <>
nit: put this before <unsigned char> just to keep ordering the same as with the
other types (like int and long) below.

https://codereview.chromium.org/1418743006/diff/1/ipc/ipc_message_utils.h#new...
ipc/ipc_message_utils.h:144: struct IPC_EXPORT ParamTraits<signed char> {
you shouldn't have to explicitly say "signed" -- I don't think there are
platforms we support where the "ambiguous signedness of char" loophole in the C
spec is actually used.

[Tom Sepez, 2015-10-29 22:30:45]

Description was changed from

==========
ipc: Add ParamTraits<signed char>

To be used by BluetoothDispatcherHost in: http://crrev.com/1317933003

BUG=549327
==========

to

==========
ipc: Add ParamTraits<signed char>

To be used by BluetoothDispatcherHost in: http://crrev.com/1317933003

BUG=549327
==========

[Tom Sepez, 2015-10-29 22:30:45]

tsepez@chromium.org changed reviewers:
+ mbarbella@chromium.org

[ortuno, 2015-10-29 22:43:34]

https://codereview.chromium.org/1418743006/diff/1/ipc/ipc_message_utils.h
File ipc/ipc_message_utils.h (right):

https://codereview.chromium.org/1418743006/diff/1/ipc/ipc_message_utils.h#new...
ipc/ipc_message_utils.h:143: template <>
On 2015/10/29 22:30:01, Tom Sepez wrote:
> nit: put this before <unsigned char> just to keep ordering the same as with
the
> other types (like int and long) below.

Done.

https://codereview.chromium.org/1418743006/diff/1/ipc/ipc_message_utils.h#new...
ipc/ipc_message_utils.h:144: struct IPC_EXPORT ParamTraits<signed char> {
On 2015/10/29 22:30:01, Tom Sepez wrote:
> you shouldn't have to explicitly say "signed" -- I don't think there are
> platforms we support where the "ambiguous signedness of char" loophole in the
C
> spec is actually used.

If I don't put the 'signed' the compiler complains when trying to send a int8_t:

../../ipc/ipc_message_utils.h:116:22: error: no member named 'Log' in
'IPC::ParamTraits<signed char>'

[Tom Sepez, 2015-10-29 22:45:53]

OK. LGTM once you make mbarbella aware of this.

[Martin Barbella, 2015-10-29 22:46:44]

Thanks for the heads up. I'll update the fuzzer.

[ortuno, 2015-10-30 00:00:31]

Looks like he's aware. Thanks!

[ortuno, 2015-10-30 00:00:34]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-10-30 00:02:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418743006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418743006/20001

[commit-bot: I haz the power, 2015-10-30 00:46:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-30 00:47:29]

Patchset 2 (id:??) landed as
https://crrev.com/19ecf184812568b0909e87fe903f2e7a62156322
Cr-Commit-Position: refs/heads/master@{#357001}