Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 1418663011: [runtime] Remove the unused weird %Likely and %Unlikely intrinsics. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove the unused weird %Likely and %Unlikely intrinsics. These intrinsics are completely unused and there doesn't seem to an actual use case for it in the future. R=mstarzinger@chromium.org Committed: https://crrev.com/9c8f4f91aab922b36d0b8c9428f0547cf021b9f3 Cr-Commit-Position: refs/heads/master@{#31828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -103 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 2 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-05 13:24:43 UTC) #1
Benedikt Meurer
Hey Michi, Another red-only CL. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-05 13:25:14 UTC) #2
Michael Starzinger
LGTM. Red good! Moar red. I like red!
5 years, 1 month ago (2015-11-05 13:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418663011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418663011/1
5 years, 1 month ago (2015-11-05 13:40:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 13:52:06 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 13:52:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c8f4f91aab922b36d0b8c9428f0547cf021b9f3
Cr-Commit-Position: refs/heads/master@{#31828}

Powered by Google App Engine
This is Rietveld 408576698