Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: test/unittests/compiler/js-intrinsic-lowering-unittest.cc

Issue 1418663011: [runtime] Remove the unused weird %Likely and %Unlikely intrinsics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-internal.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-intrinsic-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-intrinsic-lowering-unittest.cc b/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
index 71e448d698df243a3444fd7e96e5c67935b73996..a22f660c21cb20780a234ed61cb8ec7110075c8e 100644
--- a/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
+++ b/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
@@ -302,30 +302,6 @@ TEST_F(JSIntrinsicLoweringTest, InlineJSValueGetValue) {
// -----------------------------------------------------------------------------
-// %_Likely
-
-TEST_F(JSIntrinsicLoweringTest, Likely) {
- Node* const input = Parameter(0);
- Node* const context = Parameter(1);
- Node* const effect = graph()->start();
- Node* const control = graph()->start();
- Node* const likely =
- graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineLikely, 1),
- input, context, effect, control);
- Node* const to_boolean =
- graph()->NewNode(javascript()->ToBoolean(), likely, context, effect);
- Diamond d(graph(), common(), to_boolean);
- graph()->SetEnd(graph()->NewNode(common()->End(1), d.merge));
-
- ASSERT_EQ(BranchHint::kNone, BranchHintOf(d.branch->op()));
- Reduction const r = Reduce(likely);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), input);
- ASSERT_EQ(BranchHint::kTrue, BranchHintOf(d.branch->op()));
-}
-
-
-// -----------------------------------------------------------------------------
// %_MathFloor
@@ -396,30 +372,6 @@ TEST_F(JSIntrinsicLoweringTest, InlineMathClz32) {
// -----------------------------------------------------------------------------
-// %_Unlikely
-
-TEST_F(JSIntrinsicLoweringTest, Unlikely) {
- Node* const input = Parameter(0);
- Node* const context = Parameter(1);
- Node* const effect = graph()->start();
- Node* const control = graph()->start();
- Node* const unlikely =
- graph()->NewNode(javascript()->CallRuntime(Runtime::kInlineUnlikely, 1),
- input, context, effect, control);
- Node* const to_boolean =
- graph()->NewNode(javascript()->ToBoolean(), unlikely, context, effect);
- Diamond d(graph(), common(), to_boolean);
- graph()->SetEnd(graph()->NewNode(common()->End(1), d.merge));
-
- ASSERT_EQ(BranchHint::kNone, BranchHintOf(d.branch->op()));
- Reduction const r = Reduce(unlikely);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), input);
- ASSERT_EQ(BranchHint::kFalse, BranchHintOf(d.branch->op()));
-}
-
-
-// -----------------------------------------------------------------------------
// %_ValueOf
« no previous file with comments | « src/runtime/runtime-internal.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698