Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1418663006: Turn on property tree verification for PictureLayerImplTests (Closed)

Created:
5 years, 1 month ago by jaydasika
Modified:
5 years, 1 month ago
Reviewers:
Ian Vollick, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on property tree verification for PictureLayerImplTests We were not clipping the render surface content rect computed using property trees with maximum supported texture size. That resulted in property tree verification failures on some PictureLayerImplTests. This CL fixes that. BUG=538260 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7919887134cb88c0ddb31dd52091f11604475e7b Cr-Commit-Position: refs/heads/master@{#357101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M cc/layers/picture_layer_impl_unittest.cc View 11 chunks +16 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jaydasika
5 years, 1 month ago (2015-10-29 18:17:40 UTC) #2
jaydasika
5 years, 1 month ago (2015-10-30 14:30:53 UTC) #4
Ian Vollick
On 2015/10/30 14:30:53, jaydasika wrote: lgtm.
5 years, 1 month ago (2015-10-30 14:32:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418663006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418663006/1
5 years, 1 month ago (2015-10-30 14:34:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 14:43:12 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 14:44:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7919887134cb88c0ddb31dd52091f11604475e7b
Cr-Commit-Position: refs/heads/master@{#357101}

Powered by Google App Engine
This is Rietveld 408576698