Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 1418663006: Turn on property tree verification for PictureLayerImplTests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index 872db9105d0f2a292a8c1788fcae740c2f597645..cb8bc3ac116aa253591c5e848dc7bdbf983f9b3b 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -80,6 +80,7 @@ class PictureLayerImplTestSettings : public GpuRasterizationEnabledSettings {
public:
PictureLayerImplTestSettings() {
layer_transforms_should_scale_layer_contents = true;
+ verify_property_trees = true;
}
};
@@ -148,7 +149,13 @@ class PictureLayerImplTest : public testing::Test {
invalidation);
}
+ void RebuildPropertyTreesOnPendingTree() {
+ host_impl_.pending_tree()->property_trees()->needs_rebuild = true;
+ host_impl_.pending_tree()->BuildPropertyTreesForTesting();
+ }
+
void ActivateTree() {
+ RebuildPropertyTreesOnPendingTree();
host_impl_.ActivateSyncTree();
CHECK(!host_impl_.pending_tree());
CHECK(host_impl_.recycle_tree());
@@ -258,6 +265,7 @@ class PictureLayerImplTest : public testing::Test {
// Add tilings/tiles for the layer.
bool update_lcd_text = false;
+ RebuildPropertyTreesOnPendingTree();
host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);
}
@@ -1357,7 +1365,7 @@ TEST_F(PictureLayerImplTest, HugeMasksGetScaledDown) {
pending_layer_->SetMaskLayer(mask_ptr.Pass());
pending_layer_->SetHasRenderSurface(true);
- host_impl_.pending_tree()->BuildPropertyTreesForTesting();
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(1));
bool update_lcd_text = false;
host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);
@@ -1486,7 +1494,7 @@ TEST_F(PictureLayerImplTest, ScaledMaskLayer) {
pending_layer_->SetMaskLayer(mask_ptr.Pass());
pending_layer_->SetHasRenderSurface(true);
- host_impl_.pending_tree()->BuildPropertyTreesForTesting();
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(1));
bool update_lcd_text = false;
host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);
@@ -3972,6 +3980,7 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
layer1->SetContentsOpaque(true);
layer1->SetPosition(occluding_layer_position);
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(200));
bool update_lcd_text = false;
host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);
@@ -3996,6 +4005,7 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
// Full occlusion.
layer1->SetPosition(gfx::PointF());
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(200));
host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);
@@ -4064,6 +4074,7 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
layer1->SetContentsOpaque(true);
layer1->SetPosition(occluding_layer_position);
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(200));
bool update_lcd_text = false;
host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);
@@ -4101,6 +4112,7 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
// Full occlusion.
layer1->SetPosition(gfx::PointF());
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(200));
host_impl_.pending_tree()->UpdateDrawProperties(update_lcd_text);
@@ -4166,6 +4178,7 @@ TEST_F(OcclusionTrackingPictureLayerImplTest, OcclusionForDifferentScales) {
pending_layer_->AddTiling(1.0f)->set_resolution(HIGH_RESOLUTION);
pending_layer_->AddTiling(2.0f)->set_resolution(HIGH_RESOLUTION);
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(1));
// UpdateDrawProperties with the occluding layer.
bool update_lcd_text = false;
@@ -4343,6 +4356,7 @@ TEST_F(OcclusionTrackingPictureLayerImplTest,
EXPECT_EQ(1u, pending_layer_->num_tilings());
EXPECT_EQ(2u, active_layer_->num_tilings());
+ RebuildPropertyTreesOnPendingTree();
host_impl_.AdvanceToNextFrame(base::TimeDelta::FromMilliseconds(1));
// UpdateDrawProperties with the occluding layer.
bool update_lcd_text = false;
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698