third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 1418663004: SVG animateMotion paths that only cause offsets are no longer ignored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1418663004: SVG animateMotion paths that only cause offsets are no longer ignored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html ('K') | « third_party/WebKit/LayoutTests/svg/animations/script-tests/animateMotion-still.js ('k') | third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 6cef0714c8c54393249ab3155b0119353ac869b3..a26a19140864733a7e60aeba8ba994d81e0684db 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -1004,8 +1004,8 @@ void ComputedStyle::applyMotionPathTransform(float originX, float originY, Trans

FloatPoint point;

float angle;

- if (!motionPath.path().pointAndNormalAtLength(computedDistance, point, angle))

- return;

+ motionPath.path().pointAndNormalAtLength(computedDistance, point, angle);

pdr. 2015/10/30 00:52:05 There are only a few callers of these functions an

Eric Willigers 2015/11/20 07:49:53 Done.

if (motionData.m_rotationType == MotionRotationFixed)

angle = 0;