SVG animateMotion paths that only cause offsets are no longer ignored

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 986 matching lines @@
     if (motionPath.isClosed() && pathLength > 0) {
         computedDistance = fmod(distance, pathLength);
         if (computedDistance < 0)
             computedDistance += pathLength;
     } else {
         computedDistance = clampTo<float>(distance, 0, pathLength);
     }
 
     FloatPoint point;
     float angle;
-    if (!motionPath.path().pointAndNormalAtLength(computedDistance, point, angle))
-        return;
+    motionPath.path().pointAndNormalAtLength(computedDistance, point, angle);

[pdr., 2015/10/30 00:52:05]

There are only a few callers of these functions and with this change they pretty
much all ignore the "ok" param. Can we just remove "ok" entirely and update the
callsites?

[Eric Willigers, 2015/11/20 07:49:53]

Done.

+
     if (motionData.m_rotationType == MotionRotationFixed)
         angle = 0;
 
     transform.translate(point.x() - originX, point.y() - originY);
     transform.rotate(angle + motionData.m_rotation);
 }
 
 void ComputedStyle::setTextShadow(PassRefPtr<ShadowList> s)
 {
     rareInheritedData.access()->textShadow = s;
@@ skipping 780 matching lines @@
 }
 
 void ComputedStyle::copyChildDependentFlagsFrom(const ComputedStyle& other)
 {
     setEmptyState(other.emptyState());
     if (other.hasExplicitlyInheritedProperties())
         setHasExplicitlyInheritedProperties();
 }
 
 } // namespace blink