Synchronize GN build configuration with Chrome

Synchronize GN build configuration with Chrome

This is necessary to roll newer version of Native Client. We also
had to roll in new version of Gn as well as other third party libraries
to resolve various compilation issues.

BUG= https://github.com/domokit/mojo/issues/396
R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/0f5eacecbe12aae15b114a8511ae718506431b37

[Petr Hosek, 2015-10-21 00:07:10]

Patchset #5 (id:80001) has been deleted

[Petr Hosek, 2015-10-21 00:07:17]

Patchset #4 (id:60001) has been deleted

[Petr Hosek, 2015-10-21 00:08:24]

Description was changed from

==========
Synchronize GN build configuration with Chrome

BUG= https://github.com/domokit/mojo/issues/396
==========

to

==========
Synchronize GN build configuration with Chrome

This is necessary to roll newer version of Native Client. We also
had to roll in other third party libraries to resolve various issues
with GN.

BUG= https://github.com/domokit/mojo/issues/396
==========

[Petr Hosek, 2015-10-21 00:08:49]

phosek@chromium.org changed reviewers:
+ jamesr@chromium.org, smklein@chromium.org

[Petr Hosek, 2015-10-21 00:16:05]

Description was changed from

==========
Synchronize GN build configuration with Chrome

This is necessary to roll newer version of Native Client. We also
had to roll in other third party libraries to resolve various issues
with GN.

BUG= https://github.com/domokit/mojo/issues/396
==========

to

==========
Synchronize GN build configuration with Chrome

This is necessary to roll newer version of Native Client. We also
had to roll in new version of Gn as well as other third party libraries
to resolve various compilation issues.

BUG= https://github.com/domokit/mojo/issues/396
==========

[jamesr, 2015-10-21 00:32:10]

https://codereview.chromium.org/1418653002/diff/100001/build/config/compiler/...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1418653002/diff/100001/build/config/compiler/...
build/config/compiler/BUILD.gn:582: if (is_posix) {
kinda silly, all of the platforms we target are posix

https://codereview.chromium.org/1418653002/diff/100001/build/toolchain/win/BU...
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1418653002/diff/100001/build/toolchain/win/BU...
build/toolchain/win/BUILD.gn:118: command = "$python_path gyp-win-tool
asm-wrapper $env ml.exe {{defines}} {{include_dirs}} {{asmflags}} /c
/Fo{{output}} {{source}}"
why are we patching a windows toolchain file?

https://codereview.chromium.org/1418653002/diff/100001/build_overrides/v8.gni
File build_overrides/v8.gni (right):

https://codereview.chromium.org/1418653002/diff/100001/build_overrides/v8.gni...
build_overrides/v8.gni:12: v8_use_external_startup_data = !(is_chromeos ||
is_win || is_ios)
is_chromeos, is_win and is_ios are always false for our build. nuke this

https://codereview.chromium.org/1418653002/diff/100001/examples/pdf_viewer/BU...
File examples/pdf_viewer/BUILD.gn (right):

https://codereview.chromium.org/1418653002/diff/100001/examples/pdf_viewer/BU...
examples/pdf_viewer/BUILD.gn:24: "//v8:v8",
you mean "//v8"

is this new? i don't see an update to pdfium. or is the checker just more
careful now?

[jamesr, 2015-10-21 00:50:08]

Otherwise lgtm

[Petr Hosek, 2015-10-21 02:23:42]

https://chromiumcodereview.appspot.com/1418653002/diff/100001/build/config/co...
File build/config/compiler/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1418653002/diff/100001/build/config/co...
build/config/compiler/BUILD.gn:582: if (is_posix) {
On 2015/10/21 00:32:10, jamesr wrote:
> kinda silly, all of the platforms we target are posix

Removed the check.

https://chromiumcodereview.appspot.com/1418653002/diff/100001/build/toolchain...
File build/toolchain/win/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1418653002/diff/100001/build/toolchain...
build/toolchain/win/BUILD.gn:118: command = "$python_path gyp-win-tool
asm-wrapper $env ml.exe {{defines}} {{include_dirs}} {{asmflags}} /c
/Fo{{output}} {{source}}"
On 2015/10/21 00:32:10, jamesr wrote:
> why are we patching a windows toolchain file?

Dropped.

https://chromiumcodereview.appspot.com/1418653002/diff/100001/build_overrides...
File build_overrides/v8.gni (right):

https://chromiumcodereview.appspot.com/1418653002/diff/100001/build_overrides...
build_overrides/v8.gni:12: v8_use_external_startup_data = !(is_chromeos ||
is_win || is_ios)
On 2015/10/21 00:32:10, jamesr wrote:
> is_chromeos, is_win and is_ios are always false for our build. nuke this

Done.

https://chromiumcodereview.appspot.com/1418653002/diff/100001/examples/pdf_vi...
File examples/pdf_viewer/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1418653002/diff/100001/examples/pdf_vi...
examples/pdf_viewer/BUILD.gn:24: "//v8:v8",
On 2015/10/21 00:32:10, jamesr wrote:
> you mean "//v8"
> 
> is this new? i don't see an update to pdfium. or is the checker just more
> careful now?

Done.

[Petr Hosek, 2015-10-21 02:57:05]

Committed patchset #5 (id:120001) manually as
0f5eacecbe12aae15b114a8511ae718506431b37.