build/config/BUILDCONFIG.gn - Issue 1418653002: Synchronize GN build configuration with Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 1418653002: Synchronize GN build configuration with Chrome (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Review feedback addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 16495470cae54d88b9d9edb535819431627d00dc..785c8f2905eea4fea89f3e9d2d1cfa61da22370f 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -664,9 +664,6 @@ template("component") {

if (defined(invoker.direct_dependent_configs)) {

direct_dependent_configs = invoker.direct_dependent_configs

}

- if (defined(invoker.forward_dependent_configs_from)) {

- forward_dependent_configs_from = invoker.forward_dependent_configs_from

- }

if (defined(invoker.include_dirs)) {

include_dirs = invoker.include_dirs

}

@@ -755,9 +752,6 @@ template("component") {