chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java - Issue 1418613016: Do not save offline copy for error page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 1418613016: Do not save offline copy for error page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModelTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

index 9783408747d10315181b26c0289e90e760ec4981..282b8aee7d3434f22cbbbcc5357c1220c01c7d6c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

@@ -88,7 +88,8 @@ public class OfflinePageUtils {

// If an offline page is being visited, prompt that an offline copy is being shown.

save = false;

} else if (tab.getUserBookmarkId() != ChromeBrowserProviderClient.INVALID_BOOKMARK_ID

- && !tab.hasOfflineCopy() && OfflinePageBridge.canSavePage(tab.getUrl())) {

+ && !tab.hasOfflineCopy() && !tab.isShowingErrorPage()

+ && OfflinePageBridge.canSavePage(tab.getUrl())) {

// If a bookmarked page without offline copy is being visited and can be saved, offer to

// save it.

save = true;