Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java

Issue 1418613016: Do not save offline copy for error page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
index 8cc911f39db4f7f1f0514808a18497a4456df4c6..043533f3afc0b99e0ca1e57344b945368952bb89 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
@@ -207,15 +207,17 @@ public class EnhancedBookmarksModel extends BookmarksBridge {
* @param title Title of the new bookmark.
* @param url Url of the new bookmark
* @param webContents A {@link WebContents} object.
+ * @param isShowingErrorPage Whether an error page is being shown.
* @param callback The callback to be invoked when the bookmark is added.
*/
public void addBookmarkAsync(BookmarkId parent, int index, String title, String url,
- WebContents webContents, final AddBookmarkCallback callback) {
+ WebContents webContents, boolean isShowingErrorPage,
+ final AddBookmarkCallback callback) {
url = DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(url);
final BookmarkId enhancedId = addBookmark(parent, index, title, url);
// If there is no need to save offline page, return now.
- if (mOfflinePageBridge == null) {
+ if (mOfflinePageBridge == null || isShowingErrorPage) {
callback.onBookmarkAdded(enhancedId, AddBookmarkCallback.SKIPPED);
return;
}

Powered by Google App Engine
This is Rietveld 408576698