[invalidation] Componentize TiclProfileSettingsProvider

[invalidation] Componentize TiclProfileSettingsProvider

This class is shared by the iOS port, and thus needs to decouple from //chrome
dependencies for clean integration on iOS. This CL:

- Passes in the PrefService to use instead of the Profile
- Componentizes the switch and pref used
- Componentizes the unittest

BUG=519418
TBR=bartfab

Committed: https://crrev.com/390a186158cb2b6cf84274afed8eed0d47c5284c
Cr-Commit-Position: refs/heads/master@{#355244}

Committed: https://crrev.com/4e693f661ac7b9b421edd29db41069418293e53e
Cr-Commit-Position: refs/heads/master@{#356248}

[blundell, 2015-10-20 19:30:26]

blundell@chromium.org changed reviewers:
+ pavely@chromium.org

[pavely, 2015-10-21 00:18:43]

lgtm

[blundell, 2015-10-21 06:00:35]

Description was changed from

==========
[invalidation] Componentize TiclProfileSettingsProvider

This class is shared by the iOS port, and thus needs to decouple from //chrome
dependencies for clean integration on iOS. This CL:

- Passes in the PrefService to use instead of the Profile
- Componentizes the switch and pref used
- Componentizes the unittest

BUG=519418
==========

to

==========
[invalidation] Componentize TiclProfileSettingsProvider

This class is shared by the iOS port, and thus needs to decouple from //chrome
dependencies for clean integration on iOS. This CL:

- Passes in the PrefService to use instead of the Profile
- Componentizes the switch and pref used
- Componentizes the unittest

BUG=519418
TBR=bartfab
==========

[blundell, 2015-10-21 06:00:35]

blundell@chromium.org changed reviewers:
+ bartfab@chromium.org

[blundell, 2015-10-21 06:00:52]

TBR=bartfab for trivial //chrome/browser/chromeos/policy change

[blundell, 2015-10-21 06:00:59]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-10-21 06:01:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418573005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418573005/40001

[commit-bot: I haz the power, 2015-10-21 06:29:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-21 06:30:08]

Patchset 3 (id:??) landed as
https://crrev.com/390a186158cb2b6cf84274afed8eed0d47c5284c
Cr-Commit-Position: refs/heads/master@{#355244}

[bartfab (slow), 2015-10-21 14:11:42]

lgtm

[blundell, 2015-10-23 14:07:46]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1421843002/ by blundell@chromium.org.

The reason for reverting is: This CL eliminated registration of the
invalidation_service.use_gcm_channel pref on Android, but that pref is actually
used on Android (I had mistakenly thought it wasn't)..

[blundell, 2015-10-26 12:43:19]

Description was changed from

==========
[invalidation] Componentize TiclProfileSettingsProvider

This class is shared by the iOS port, and thus needs to decouple from //chrome
dependencies for clean integration on iOS. This CL:

- Passes in the PrefService to use instead of the Profile
- Componentizes the switch and pref used
- Componentizes the unittest

BUG=519418
TBR=bartfab

Committed: https://crrev.com/390a186158cb2b6cf84274afed8eed0d47c5284c
Cr-Commit-Position: refs/heads/master@{#355244}
==========

to

==========
[invalidation] Componentize TiclProfileSettingsProvider

This class is shared by the iOS port, and thus needs to decouple from //chrome
dependencies for clean integration on iOS. This CL:

- Passes in the PrefService to use instead of the Profile
- Componentizes the switch and pref used
- Componentizes the unittest

BUG=519418
TBR=bartfab

Committed: https://crrev.com/390a186158cb2b6cf84274afed8eed0d47c5284c
Cr-Commit-Position: refs/heads/master@{#355244}
==========

[blundell, 2015-10-26 13:30:09]

Patchset #4 (id:60001) has been deleted

[blundell, 2015-10-26 14:38:52]

Hi Pavel,

Could you take a look at the delta between PS4 and PS5, which has the fix for
Android? Thanks!

[pavely, 2015-10-26 23:32:21]

lgtm

[blundell, 2015-10-27 07:09:44]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-10-27 07:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from bartfab@chromium.org
Link to the patchset: https://codereview.chromium.org/1418573005/#ps100001
(title: "Maintain pref registration on Android")

[commit-bot: I haz the power, 2015-10-27 07:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418573005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418573005/100001

[commit-bot: I haz the power, 2015-10-27 07:14:24]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-10-27 07:15:05]

Patchset 5 (id:??) landed as
https://crrev.com/4e693f661ac7b9b421edd29db41069418293e53e
Cr-Commit-Position: refs/heads/master@{#356248}