components/invalidation/impl/ticl_profile_settings_provider.h - Issue 1418573005: [invalidation] Componentize TiclProfileSettingsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/ticl_profile_settings_provider.h

Issue 1418573005: [invalidation] Componentize TiclProfileSettingsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Maintain pref registration on Android Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/invalidation/impl/profile_invalidation_provider.cc ('k') | components/invalidation/impl/ticl_profile_settings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/impl/ticl_profile_settings_provider.h

diff --git a/chrome/browser/invalidation/ticl_profile_settings_provider.h b/components/invalidation/impl/ticl_profile_settings_provider.h

similarity index 70%

rename from chrome/browser/invalidation/ticl_profile_settings_provider.h

rename to components/invalidation/impl/ticl_profile_settings_provider.h

index 56f970cccdc0570200a0168bac7a977a83a7041b..83841ba758c04e12b0440e177030d34a63569067 100644

--- a/chrome/browser/invalidation/ticl_profile_settings_provider.h

+++ b/components/invalidation/impl/ticl_profile_settings_provider.h

@@ -2,22 +2,22 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROME_BROWSER_INVALIDATION_TICL_PROFILE_SETTINGS_PROVIDER_H_

-#define CHROME_BROWSER_INVALIDATION_TICL_PROFILE_SETTINGS_PROVIDER_H_

+#ifndef COMPONENTS_INVALIDATION_IMPL_TICL_PROFILE_SETTINGS_PROVIDER_H_

+#define COMPONENTS_INVALIDATION_IMPL_TICL_PROFILE_SETTINGS_PROVIDER_H_

#include "base/compiler_specific.h"

#include "base/macros.h"

#include "base/prefs/pref_change_registrar.h"

#include "components/invalidation/impl/ticl_settings_provider.h"

-class Profile;

+class PrefService;

namespace invalidation {

// A specialization of TiclSettingsProvider that reads settings from user prefs.

class TiclProfileSettingsProvider : public TiclSettingsProvider {

public:

- explicit TiclProfileSettingsProvider(Profile* profile);

+ explicit TiclProfileSettingsProvider(PrefService* prefs);

~TiclProfileSettingsProvider() override;

// TiclInvalidationServiceSettingsProvider:

@@ -25,11 +25,11 @@ class TiclProfileSettingsProvider : public TiclSettingsProvider {

private:

PrefChangeRegistrar registrar_;

- Profile* const profile_;

+ PrefService* const prefs_;

DISALLOW_COPY_AND_ASSIGN(TiclProfileSettingsProvider);

};

} // namespace invalidation

-#endif // CHROME_BROWSER_INVALIDATION_TICL_PROFILE_SETTINGS_PROVIDER_H_

+#endif // COMPONENTS_INVALIDATION_IMPL_TICL_PROFILE_SETTINGS_PROVIDER_H_