Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 141853002: [Android] Revert for regression where gestures interrupted on page load (Closed)

Created:
6 years, 11 months ago by jdduke (slow)
Modified:
6 years, 11 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Revert for regression where gestures interrupted on page load This is a partial revert of https://codereview.chromium.org/120203003. It is quite common for a page to generate multiple |DidStartLoading()| notifications while it finishes loading. Redundant notifications should not reset a gesture mid-sequence. BUG=335586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245630

Patch Set 1 #

Patch Set 2 : Proper fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jdduke (slow)
wangxianzhu@: PTAL. It's really quite odd that we get so many spammy |DidStartLoading()| notifications. I ...
6 years, 11 months ago (2014-01-17 18:10:08 UTC) #1
Xianzhu
lgtm. It's interesting that didStartLoading is called multiple times. Perhaps it's also called for subdocuments. ...
6 years, 11 months ago (2014-01-17 18:32:06 UTC) #2
jdduke (slow)
On 2014/01/17 18:32:06, Xianzhu wrote: > lgtm. > > It's interesting that didStartLoading is called ...
6 years, 11 months ago (2014-01-17 18:36:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/141853002/30001
6 years, 11 months ago (2014-01-17 18:37:16 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=248182
6 years, 11 months ago (2014-01-17 20:30:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/141853002/30001
6 years, 11 months ago (2014-01-17 20:42:50 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 21:51:01 UTC) #7
Message was sent while issue was closed.
Change committed as 245630

Powered by Google App Engine
This is Rietveld 408576698