Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 120203003: [Android] Send TapCancel if necessary when a touch gesture is consumed (Closed)

Created:
6 years, 12 months ago by jdduke (slow)
Modified:
6 years, 12 months ago
Reviewers:
Ted C
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Send TapCancel if necessary when a touch gesture is consumed When a TouchStart is unconsumed by Javascript, a GestureTapDown is sent immediately, potentially followed by a GestureShowPress. Fix the case where the subsequent Touch{Move,End} is consumed by Javascript by synthesizing a GestureTapCancel. BUG=330718 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242553

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix indentation #

Patch Set 3 : More indentation fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -6 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java View 1 2 3 chunks +52 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jdduke (slow)
tedchoc@: PTAL... not sure if anybody else is around for the next few days =/
6 years, 12 months ago (2013-12-26 18:15:07 UTC) #1
Ted C
lgtm w/ some nits https://codereview.chromium.org/120203003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java File content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java (right): https://codereview.chromium.org/120203003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java#newcode2273 content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java:2273: ContentViewGestureHandler.INPUT_EVENT_ACK_STATE_NOT_CONSUMED); +4 indent https://codereview.chromium.org/120203003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java#newcode2279 content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java:2279: ...
6 years, 12 months ago (2013-12-26 18:27:45 UTC) #2
jdduke (slow)
Copy+paste strikes again, thanks! https://codereview.chromium.org/120203003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java File content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java (right): https://codereview.chromium.org/120203003/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java#newcode2273 content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java:2273: ContentViewGestureHandler.INPUT_EVENT_ACK_STATE_NOT_CONSUMED); On 2013/12/26 18:27:45, Ted ...
6 years, 12 months ago (2013-12-26 18:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/120203003/90003
6 years, 12 months ago (2013-12-26 18:35:05 UTC) #4
commit-bot: I haz the power
6 years, 12 months ago (2013-12-26 21:16:49 UTC) #5
Message was sent while issue was closed.
Change committed as 242553

Powered by Google App Engine
This is Rietveld 408576698