[sync] Set up notification-free infra for triggering local sync refresh

[sync] Set up notification-free infra for triggering local sync refresh

Sync code that is due to be componentized and shared with iOS both sends and
listens for the SYNC_REFRESH_LOCAL notification. This is problematic, as iOS
cannot use the //content-based notification system.

This CL puts the pieces in place for getting rid of this notification: It adds
an interface to SyncService that a client can call to trigger refresh. Future
work can change all senders of the notification to instead call into the
SyncService and then eliminate the notification altogether.

BUG=512779, 512059
Committed: https://crrev.com/ce26a15f734e6be603bf8c62e07c884a7c344419
Cr-Commit-Position: refs/heads/master@{#356021}

[blundell, 2015-10-23 12:36:57]

Description was changed from

==========
[sync] Set up notification-free infa for triggering local sync refresh

Sync code that is due to be componentized and shared with iOS both sends and
listens for the SYNC_REFRESH_LOCAL notification. This is problematic, as iOS
cannot use the //content-based notification system.

This CL puts the pieces in place for getting rid of this notification: It adds
an interface to SyncService that a client can call to trigger refresh. Future
work can change all senders of the notification to instead call into the
SyncService and then eliminate the notification altogether.

BUG=512779,512059
==========

to

==========
[sync] Set up notification-free infra for triggering local sync refresh

Sync code that is due to be componentized and shared with iOS both sends and
listens for the SYNC_REFRESH_LOCAL notification. This is problematic, as iOS
cannot use the //content-based notification system.

This CL puts the pieces in place for getting rid of this notification: It adds
an interface to SyncService that a client can call to trigger refresh. Future
work can change all senders of the notification to instead call into the
SyncService and then eliminate the notification altogether.

BUG=512779,512059
==========

[blundell, 2015-10-23 14:35:14]

blundell@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2015-10-23 20:20:10]

lgtm

https://codereview.chromium.org/1418513005/diff/1/components/sync_driver/sync...
File components/sync_driver/sync_service.h (right):

https://codereview.chromium.org/1418513005/diff/1/components/sync_driver/sync...
components/sync_driver/sync_service.h:106: // Triggers refresh of sync state.
nit: prefer being more specific about what this does in the comment. Perhaps
"Triggers a GetUpdates for the specified |types|, pulling any new data from the
sync server".

[blundell, 2015-10-26 07:59:36]

https://codereview.chromium.org/1418513005/diff/1/components/sync_driver/sync...
File components/sync_driver/sync_service.h (right):

https://codereview.chromium.org/1418513005/diff/1/components/sync_driver/sync...
components/sync_driver/sync_service.h:106: // Triggers refresh of sync state.
On 2015/10/23 20:20:10, Nicolas Zea wrote:
> nit: prefer being more specific about what this does in the comment. Perhaps
> "Triggers a GetUpdates for the specified |types|, pulling any new data from
the
> sync server".

Done.

[blundell, 2015-10-26 07:59:39]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-10-26 07:59:40]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1418513005/#ps20001
(title: "Response to review")

[commit-bot: I haz the power, 2015-10-26 07:59:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418513005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418513005/20001

[commit-bot: I haz the power, 2015-10-26 08:39:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-26 08:40:06]

Patchset 2 (id:??) landed as
https://crrev.com/ce26a15f734e6be603bf8c62e07c884a7c344419
Cr-Commit-Position: refs/heads/master@{#356021}