Check that AnalysisContext is not null.

Check that AnalysisContext is not null.

I guess this happens when a "resolved" CompilationUnit is not actially resolved.
I don't know why we get such units, but I saw this situation twice in IDEA.
So, probably we need to fix at least throwing NPE here.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5f71b2e7cd3137fe4e8b7b58bb04b8c1f32129bf

[Brian Wilkerson, 2015-10-19 19:57:04]

LGTM, but with a serious caveat.

https://codereview.chromium.org/1418513002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/store/split_store.dart (right):

https://codereview.chromium.org/1418513002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/store/split_store.dart:816: if
(context == null || context.isDisposed) {
I'm concerned that we're masking a deeper bug. Could we add an assert statement
here, or log information about what happened (although if it's happening a lot
that could negatively impact instrumentation)?

[scheglov, 2015-10-19 20:25:46]

https://codereview.chromium.org/1418513002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/store/split_store.dart (right):

https://codereview.chromium.org/1418513002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/store/split_store.dart:816: if
(context == null || context.isDisposed) {
On 2015/10/19 19:57:03, Brian Wilkerson wrote:
> I'm concerned that we're masking a deeper bug. Could we add an assert
statement
> here, or log information about what happened (although if it's happening a lot
> that could negatively impact instrumentation)?

We're definitely are masking a bug here.
But for now I'm more concerned about fixing the problem.

I've opened a new issue to track the problem.
https://github.com/dart-lang/sdk/issues/24629

[scheglov, 2015-10-19 20:27:56]

Committed patchset #1 (id:1) manually as
5f71b2e7cd3137fe4e8b7b58bb04b8c1f32129bf (presubmit successful).