Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: pkg/analysis_server/lib/src/services/index/store/split_store.dart

Issue 1418513002: Check that AnalysisContext is not null. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/index/store/split_store_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/index/store/split_store.dart
diff --git a/pkg/analysis_server/lib/src/services/index/store/split_store.dart b/pkg/analysis_server/lib/src/services/index/store/split_store.dart
index eed774fd90d287e2e26c0539be416c4d9c72c421..880cad3a82c51bb38bac844567fa88580e64a08c 100644
--- a/pkg/analysis_server/lib/src/services/index/store/split_store.dart
+++ b/pkg/analysis_server/lib/src/services/index/store/split_store.dart
@@ -813,7 +813,7 @@ class SplitIndexStore implements InternalIndexStore {
@override
bool aboutToIndex(AnalysisContext context, Object object) {
- if (context.isDisposed) {
+ if (context == null || context.isDisposed) {
Brian Wilkerson 2015/10/19 19:57:03 I'm concerned that we're masking a deeper bug. Cou
scheglov 2015/10/19 20:25:46 We're definitely are masking a bug here. But for n
return false;
}
// try to find a node name
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/index/store/split_store_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698