Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_controller.cc

Issue 1418503012: [Ozone-DRM] Remove bool return value for SchedulePageFlip call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/hardware_display_controller.cc
diff --git a/ui/ozone/platform/drm/gpu/hardware_display_controller.cc b/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
index a377e8bafa46547689d804528413d9db7ff6a9a2..1b503c558f8bb440ca8b894bc44d00b643f778c0 100644
--- a/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
+++ b/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
@@ -23,6 +23,12 @@
namespace ui {
+namespace {
+
+void EmptyFlipCallback(gfx::SwapResult) {}
+
+} // namespace
+
HardwareDisplayController::HardwareDisplayController(
scoped_ptr<CrtcController> controller,
const gfx::Point& origin)
@@ -72,7 +78,19 @@ void HardwareDisplayController::Disable() {
is_disabled_ = true;
}
-bool HardwareDisplayController::SchedulePageFlip(
+void HardwareDisplayController::SchedulePageFlip(
+ const OverlayPlaneList& plane_list,
+ const PageFlipCallback& callback) {
+ ActualSchedulePageFlip(plane_list, false /* test_only */, callback);
+}
+
+bool HardwareDisplayController::TestPageFlip(
+ const OverlayPlaneList& plane_list) {
+ return ActualSchedulePageFlip(plane_list, true /* test_only */,
+ base::Bind(&EmptyFlipCallback));
+}
+
+bool HardwareDisplayController::ActualSchedulePageFlip(
spang 2015/10/29 20:59:20 This only moves the problem to ActualSchedulePageF
dnicoara 2015/10/30 14:59:31 Yes, though DrmWindow::TestPageFlip() has some all
const OverlayPlaneList& plane_list,
bool test_only,
const PageFlipCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698