Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_controller.h

Issue 1418503012: [Ozone-DRM] Remove bool return value for SchedulePageFlip call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/hardware_display_controller.h
diff --git a/ui/ozone/platform/drm/gpu/hardware_display_controller.h b/ui/ozone/platform/drm/gpu/hardware_display_controller.h
index 093a42e5492ca233cf24361a3bf04fae0ec38a90..a561908564fb38d217a8984ffb2b08e3d8e5ee0f 100644
--- a/ui/ozone/platform/drm/gpu/hardware_display_controller.h
+++ b/ui/ozone/platform/drm/gpu/hardware_display_controller.h
@@ -118,15 +118,13 @@ class OZONE_EXPORT HardwareDisplayController {
//
// Note that this function does not block. Also, this function should not be
// called again before the page flip occurrs.
- //
- // Returns true if the page flip was successfully registered, false otherwise.
- //
- // When called with |test_only| true, this performs the page flip without
- // changing any state, reporting if this page flip would be allowed to occur.
- bool SchedulePageFlip(const OverlayPlaneList& plane_list,
- bool test_only,
+ void SchedulePageFlip(const OverlayPlaneList& plane_list,
const PageFlipCallback& callback);
+ // Returns true if the page flip with the |plane_list| would succeed. This
+ // doesn't change any state.
+ bool TestPageFlip(const OverlayPlaneList& plane_list);
+
std::vector<uint32_t> GetCompatibleHardwarePlaneIds(
const OverlayPlane& plane) const;
@@ -158,6 +156,10 @@ class OZONE_EXPORT HardwareDisplayController {
scoped_refptr<DrmDevice> GetAllocationDrmDevice() const;
private:
+ bool ActualSchedulePageFlip(const OverlayPlaneList& plane_list,
+ bool test_only,
+ const PageFlipCallback& callback);
+
base::ScopedPtrHashMap<DrmDevice*, scoped_ptr<HardwareDisplayPlaneList>>
owned_hardware_planes_;

Powered by Google App Engine
This is Rietveld 408576698