Issue 1418493006: Merge to XFA: Cleanup CPDF_Stream:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1418493006: Merge to XFA: Cleanup CPDF_Stream: (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Cleanup CPDF_Stream: - Remove CPDF_Stream::Create() and checks that it might fail. - Remove m_pCryptoHandler that's always a nullptr. - Remove m_FileOffset that's always 0. - Rename file version of InitStream() to InitStreamFromFile(). - Use IsMemoryBased() in more places. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1415163009 . (cherry picked from commit e6e16954f0cdc324849fca9da883be8f131b3834) Committed: https://pdfium.googlesource.com/pdfium/+/61aad4fbb6fb1081a40b2e144106f57cf443846c

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -121 lines)			Patch
M	core/include/fpdfapi/fpdf_objects.h	View		5 chunks	+9 lines, -18 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View		7 chunks	+71 lines, -89 lines	0 comments	Download
M	core/src/fpdfdoc/doc_ap.cpp	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/fpdfsave.cpp	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-11-10 18:29:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
61aad4fbb6fb1081a40b2e144106f57cf443846c (presubmit successful).