Cleanup CPDF_Stream:

Cleanup CPDF_Stream:

- Remove CPDF_Stream::Create() and checks that it might fail.
- Remove m_pCryptoHandler that's always a nullptr.
- Remove m_FileOffset that's always 0.
- Rename file version of InitStream() to InitStreamFromFile().
- Use IsMemoryBased() in more places.

R=dsinclair@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/e6e16954f0cdc324849fca9da883be8f131b3834

[Lei Zhang, 2015-11-10 08:14:11]

Description was changed from

==========
Cleanup CPDF_Stream:

- Remove CPDF_Stream::Create() and checks that it might fail.
- Remove m_pCryptoHandler that's always a nullptr.
- Rename file version of InitStream() to InitStreamFromFile().
- Use IsMemoryBased() in more places.
==========

to

==========
Cleanup CPDF_Stream:

- Remove CPDF_Stream::Create() and checks that it might fail.
- Remove m_pCryptoHandler that's always a nullptr.
- Remove m_FileOffset that's always 0.
- Rename file version of InitStream() to InitStreamFromFile().
- Use IsMemoryBased() in more places.
==========

[Lei Zhang, 2015-11-10 08:14:11]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2015-11-10 17:32:37]

lgtm w/ nits.

https://codereview.chromium.org/1415163009/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1415163009/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:866: m_GenNum =
kMemoryBasedGenNum;
It would be clearer to always do this assignment. Either we're already memory
based, or we're going to set ourselves to memory based now.

https://codereview.chromium.org/1415163009/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:956: const FX_DWORD
kBlockSize = 1024;
This is defined twice, here are 922, can we move it to an anonymous namespace at
the start?

[Lei Zhang, 2015-11-10 18:18:06]

https://codereview.chromium.org/1415163009/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1415163009/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:866: m_GenNum =
kMemoryBasedGenNum;
On 2015/11/10 17:32:36, dsinclair wrote:
> It would be clearer to always do this assignment. Either we're already memory
> based, or we're going to set ourselves to memory based now.

Done.

https://codereview.chromium.org/1415163009/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:956: const FX_DWORD
kBlockSize = 1024;
On 2015/11/10 17:32:36, dsinclair wrote:
> This is defined twice, here are 922, can we move it to an anonymous namespace
at
> the start?

Done.

[Lei Zhang, 2015-11-10 18:23:35]

Committed patchset #4 (id:60001) manually as
e6e16954f0cdc324849fca9da883be8f131b3834 (presubmit successful).