Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1418483003: Revert of ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder. (Closed)

Created:
5 years, 2 months ago by reveman
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, ericrk, feature-media-reviews_chromium.org, jam, kalyank, mcasas+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder. (patchset #15 id:280001 of https://codereview.chromium.org/1401423003/ ) Reason for revert: Causing android gpu bots to fail Original issue's description: > ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder. > > This allows the GPU service to properly track the memory usage > image backed textures. > > It also reduces the complexity of GLImage implementations > significantly and makes it easier to support format and > buffer types that require a copy or conversion of data to > be used for sampling. > > This change also includes a few minor GLImage cleanups such > as removing gfx:: namespace prefix in places where it's not > needed and making the CopyTexImage GLImage test not part of > the core GLImage tests as it's optional to support that > function. > > BUG=526298 > TEST=gl_tests --gtest_filter=GpuMemoryBuffer*, gpu_unittests, gl_unittests --gtest_filter=GLImage* > > Committed: https://crrev.com/ac2696e324bda3824952148f831e76a8b80594b3 > Cr-Commit-Position: refs/heads/master@{#354870} TBR=dcastagna@chromium.org,ericrk@chromium.org,fsamuel@chromium.org,liberato@chromium.org,sievers@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=526298 Committed: https://crrev.com/44429f23f3899d52c9493c114ae9b62e1ddeb7af Cr-Commit-Position: refs/heads/master@{#354914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+884 lines, -565 lines) Patch
M components/mus/gles2/command_buffer_local.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/common/gpu/media/android_deferred_rendering_backing_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/avda_codec_image.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/gpu/media/avda_codec_image.cc View 3 chunks +23 lines, -27 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/gpu/stream_texture_android.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/gpu/stream_texture_android.cc View 5 chunks +4 lines, -22 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 6 chunks +37 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 6 chunks +47 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 42 chunks +208 lines, -86 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 9 chunks +61 lines, -40 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_sync.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/stream_texture_manager_in_process_android.cc View 6 chunks +14 lines, -32 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 5 chunks +24 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 6 chunks +16 lines, -32 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 8 chunks +35 lines, -32 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_image.h View 3 chunks +17 lines, -15 lines 0 comments Download
M ui/gl/gl_image_egl.h View 2 chunks +8 lines, -5 lines 0 comments Download
M ui/gl/gl_image_egl.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M ui/gl/gl_image_glx.h View 2 chunks +8 lines, -5 lines 0 comments Download
M ui/gl/gl_image_glx.cc View 10 chunks +28 lines, -26 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 3 chunks +13 lines, -10 lines 0 comments Download
M ui/gl/gl_image_io_surface.mm View 8 chunks +10 lines, -18 lines 0 comments Download
M ui/gl/gl_image_memory.h View 3 chunks +27 lines, -2 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 7 chunks +202 lines, -30 lines 0 comments Download
M ui/gl/gl_image_ozone_native_pixmap.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_ozone_native_pixmap.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M ui/gl/gl_image_ref_counted_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_image_ref_counted_memory.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M ui/gl/gl_image_ref_counted_memory_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_image_shared_memory.h View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/gl/gl_image_shared_memory.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M ui/gl/gl_image_shared_memory_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_image_stub.h View 1 chunk +6 lines, -3 lines 0 comments Download
M ui/gl/gl_image_stub.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ui/gl/gl_image_surface_texture.h View 2 chunks +8 lines, -5 lines 0 comments Download
M ui/gl/gl_image_surface_texture.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M ui/gl/gl_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/test/gl_image_test_template.h View 4 chunks +10 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reveman
Created Revert of ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder.
5 years, 2 months ago (2015-10-19 23:36:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418483003/1
5 years, 2 months ago (2015-10-19 23:37:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 23:38:57 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 23:40:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44429f23f3899d52c9493c114ae9b62e1ddeb7af
Cr-Commit-Position: refs/heads/master@{#354914}

Powered by Google App Engine
This is Rietveld 408576698