Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1418483002: password_manager_switches.h: Remove dangling declarations (Closed)

Created:
5 years, 2 months ago by vabr (Chromium)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

password_manager_switches.h: Remove dangling declarations The definitions of kDisablePasswordLink and kEnablePasswordLink were removed in https://codereview.chromium.org/1396403004/, but the declarations were kept by mistake. This CL removes the dangling declarations. R=eugenebut@chromium.org BUG=480552 Committed: https://crrev.com/1dc1994b3894bcff5f247ac850a0b7f0d2a80f6e Cr-Commit-Position: refs/heads/master@{#354836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M components/password_manager/core/common/password_manager_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vabr (Chromium)
Thanks, eugenebut@, for spotting this in https://codereview.chromium.org/1396403004/#msg27. PTAL. Cheers, Vaclav
5 years, 2 months ago (2015-10-19 18:52:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418483002/1
5 years, 2 months ago (2015-10-19 18:55:23 UTC) #3
Eugene But (OOO till 7-30)
lgtm, please update CL description to fit 72 symbols
5 years, 2 months ago (2015-10-19 18:55:59 UTC) #4
vabr (Chromium)
On 2015/10/19 18:55:59, eugenebut wrote: > lgtm, please update CL description to fit 72 symbols ...
5 years, 2 months ago (2015-10-19 19:00:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418483002/1
5 years, 2 months ago (2015-10-19 19:05:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 19:55:49 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 19:56:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dc1994b3894bcff5f247ac850a0b7f0d2a80f6e
Cr-Commit-Position: refs/heads/master@{#354836}

Powered by Google App Engine
This is Rietveld 408576698