Issue 1418453017: Fix some minor bugs related to imports in the new mojom bindings generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1418453017: Fix some minor bugs related to imports in the new mojom bindings generator. (Closed)

Created:
5 years, 1 month ago by azani

Modified:
5 years, 1 month ago

Reviewers:
rudominer

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix some minor bugs related to imports in the new mojom bindings generator. Fix the issue where imported modules could not be correctly processed. Fix the issue where module.py was choking because of a lack of spec strings on user defined types. R=rudominer@chromium.org, rudominer BUG= #461 Committed: https://chromium.googlesource.com/external/mojo/+/58edc6fd419f9f7d9beed66ce4d0c968fedde572

Patch Set 1 #

Patch Set 2 : Fix tests. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
M	mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/public/tools/bindings/run_code_generators.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

azani

5 years, 1 month ago (2015-11-11 21:26:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
58edc6fd419f9f7d9beed66ce4d0c968fedde572 (presubmit successful).

Expand Messages | Collapse Messages