mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py - Issue 1418453017: Fix some minor bugs related to imports in the new mojom bindings generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py

Issue 1418453017: Fix some minor bugs related to imports in the new mojom bindings generator. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py ('k') | mojo/public/tools/bindings/run_code_generators.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py b/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py

index db82f88852150e986aa6bd41b4f04c4d1723acb4..c8a3ed8865061a2049280222d8dd9522cf7ce367 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py

@@ -356,7 +356,8 @@ class TestUserDefinedTypeFromMojom(unittest.TestCase):

type_reference=mojom_types_mojom.TypeReference(

type_key=type_key)))

- self.assertIsNone(struct.module)

+ self.assertEquals(

+ translator._imports['root/c.mojom']['module'], struct.module)

self.assertEquals(translator._imports['root/c.mojom'], struct.imported_from)

def test_interface(self):