Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1418453009: Devtools UI: Colorize node links and make pseudo links clearer (Closed)

Created:
5 years, 1 month ago by samli
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools UI: Colorize node links and make pseudo links clearer Committed: https://crrev.com/25977703a820e2e0d2dcb1db5fcd9d4f03665e03 Cr-Commit-Position: refs/heads/master@{#358740}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -12 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 4 chunks +21 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/domUtils.css View 1 2 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
samli
http://i.imgur.com/LPTKgmm.png http://i.imgur.com/KTmZq44.png
5 years, 1 month ago (2015-11-06 22:18:14 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-11-09 23:05:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418453009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418453009/1
5 years, 1 month ago (2015-11-09 23:27:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/120899) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-09 23:32:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418453009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418453009/20001
5 years, 1 month ago (2015-11-09 23:49:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 01:51:04 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 01:52:33 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/25977703a820e2e0d2dcb1db5fcd9d4f03665e03
Cr-Commit-Position: refs/heads/master@{#358740}

Powered by Google App Engine
This is Rietveld 408576698