Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1418453007: Merge to XFA: Add support for building with goma. (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add support for building with goma. TBR=thestig@chromium.org clean merge. Review URL: https://codereview.chromium.org/1428093004 . (cherry picked from commit e35b445bee90390ea09f334cbff4a6220537bbda) Committed: https://pdfium.googlesource.com/pdfium/+/14591ce728525ab065d71a8598f9b201d0395db8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M README.md View 1 chunk +10 lines, -0 lines 0 comments Download
M build/standalone.gypi View 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Oliver Chang
Committed patchset #1 (id:1) manually as 14591ce728525ab065d71a8598f9b201d0395db8 (presubmit successful).
5 years, 1 month ago (2015-11-03 21:12:50 UTC) #1
Lei Zhang
5 years, 1 month ago (2015-11-03 21:16:13 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698