Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1428093004: Add support for building with goma. (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang, Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : documentation #

Patch Set 3 : nit #

Patch Set 4 : another nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M README.md View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 2 3 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Oliver Chang
5 years, 1 month ago (2015-11-03 20:58:12 UTC) #3
Oliver Chang
ptal
5 years, 1 month ago (2015-11-03 20:58:21 UTC) #4
Nico
lgtm (do you have any with / without goma build numbers? pdfium is fairly small, ...
5 years, 1 month ago (2015-11-03 21:01:12 UTC) #5
Lei Zhang
On 2015/11/03 21:01:12, Nico wrote: > lgtm > > (do you have any with / ...
5 years, 1 month ago (2015-11-03 21:05:45 UTC) #6
Oliver Chang
On 2015/11/03 21:01:12, Nico wrote: > lgtm > > (do you have any with / ...
5 years, 1 month ago (2015-11-03 21:06:14 UTC) #7
Oliver Chang
5 years, 1 month ago (2015-11-03 21:09:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
e35b445bee90390ea09f334cbff4a6220537bbda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698