Issue 141843002: Revert 245509 "net: Use FileStream asynchronously from UploadFil..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141843002: Revert 245509 "net: Use FileStream asynchronously from UploadFil..." (Closed)

Created:
6 years, 11 months ago by Mark Mentovai

Modified:
6 years, 11 months ago

Reviewers:
hashimoto

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 245509 "net: Use FileStream asynchronously from UploadFil..." This caused XP Tests (2) net_unittests NextProto/HttpNetworkTransactionTest.UploadFileSmallerThanLength/0, /1, /2, /3, /4, and UploadDataStreamTest.FileSmallerThanLength to time out. http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/32723/ > net: Use FileStream asynchronously from UploadFileElementReader > > InitInternal() and ReadInternal() were used to share the same implementation with UploadFileElementReaderSync. > There is no need to maintain them since UploadFileElementReaderSync is gone. > Abandon these unneeded functions and use FileStream in an asynchronous way. > > BUG=294797 > TEST=net_unittests > > Review URL: https://codereview.chromium.org/139253002 TBR=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245529

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -110 lines)			Patch
	M	trunk/src/net/base/upload_file_element_reader.h	View		4 chunks	+23 lines, -9 lines	0 comments	Download
	M	trunk/src/net/base/upload_file_element_reader.cc	View		5 chunks	+140 lines, -101 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

6 years, 11 months ago (2014-01-17 16:39:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r245529 (tree was closed).

Expand Messages | Collapse Messages