net: Use FileStream asynchronously from UploadFileElementReader

net: Use FileStream asynchronously from UploadFileElementReader

InitInternal() and ReadInternal() were used to share the same implementation with UploadFileElementReaderSync.
There is no need to maintain them since UploadFileElementReaderSync is gone.
Abandon these unneeded functions and use FileStream in an asynchronous way.

BUG=294797
TEST=net_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245509

[hashimoto, 2014-01-15 10:24:29]

Some more clean up!
Please review.

[mmenke, 2014-01-15 15:13:55]

LGTM!  Nice cleanup.

https://chromiumcodereview.appspot.com/139253002/diff/60001/net/base/upload_f...
File net/base/upload_file_element_reader.cc (right):

https://chromiumcodereview.appspot.com/139253002/diff/60001/net/base/upload_f...
net/base/upload_file_element_reader.cc:80: const uint64 num_bytes_to_read =
Suggest not using the const, since it's fairly uncommon.

[hashimoto, 2014-01-16 09:57:36]

Was hit by TSAN failure.
Waiting for the UploadData removal patch to reland...
(https://codereview.chromium.org/140733002/)

https://codereview.chromium.org/139253002/diff/60001/net/base/upload_file_ele...
File net/base/upload_file_element_reader.cc (right):

https://codereview.chromium.org/139253002/diff/60001/net/base/upload_file_ele...
net/base/upload_file_element_reader.cc:80: const uint64 num_bytes_to_read =
On 2014/01/15 15:13:55, mmenke wrote:
> Suggest not using the const, since it's fairly uncommon.

Done.

[commit-bot: I haz the power, 2014-01-17 10:07:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/139253002/170001

[commit-bot: I haz the power, 2014-01-17 14:03:16]

Change committed as 245509