Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/SkBitmapRegionSampler.h

Issue 1418093006: Refactor SkBitmapRegionDecoderInterface for Android (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/SkBitmapRegionSampler.h
diff --git a/tools/SkBitmapRegionSampler.h b/tools/SkBitmapRegionSampler.h
index 8ed95e25249b1cd4092fd095ca601c8c4164a33d..ac70030dc60310bf19a30d5e3fb47ffb18ff950e 100644
--- a/tools/SkBitmapRegionSampler.h
+++ b/tools/SkBitmapRegionSampler.h
@@ -22,28 +22,20 @@ public:
*/
SkBitmapRegionSampler(SkImageDecoder* decoder, int width, int height);
- /*
- * Three differences from the Android version:
- * Returns a Skia bitmap instead of an Android bitmap.
- * Android version attempts to reuse a recycled bitmap.
- * Removed the options object and used parameters for color type and
- * sample size.
- */
- SkBitmap* decodeRegion(int start_x, int start_y, int width, int height,
- int sampleSize, SkColorType prefColorType) override;
+ bool prepareRegion(const SkIRect& desiredSubset, int sampleSize,
+ SkColorType colorType, bool requireUnpremul, SkImageInfo* outSize) override;
- bool conversionSupported(SkColorType colorType) override {
- // SkBitmapRegionSampler does not allow the client to check if the conversion
- // is supported. We will return true as a default. If the conversion is in
- // fact not supported, decodeRegion() will ignore the prefColorType and choose
- // its own color type. We catch this and fail non-fatally in our test code.
- return true;
- }
+ bool decodeRegion(SkBitmap& bitmap) override;
private:
SkAutoTDelete<SkImageDecoder> fDecoder;
+
+ // Fields set by prepareRegion()
+ SkIRect fSubset; // Subset of the original image to decode
+ SkColorType fColorType; // Color type to decode to
+
typedef SkBitmapRegionDecoderInterface INHERITED;
};

Powered by Google App Engine
This is Rietveld 408576698