chrome/browser/ssl/ssl_browser_tests.cc - Issue 1418003006: Simplify starting a navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1418003006: Simplify starting a navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 200989ef441a84bec383233baacd31fefb43a2d9..20b789851ab8ed50fd657e31b4d11c59b295bb2f 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -2599,6 +2599,8 @@ IN_PROC_BROWSER_TEST_F(CommonNameMismatchBrowserTest,

CheckSecurityState(contents, CertError::NONE,

content::SECURITY_STYLE_AUTHENTICATED, AuthState::NONE);

replacements.SetHostStr("mail.example.com");

+ // blink strips the ref from requests.

+ replacements.ClearRef();

GURL https_server_new_url = https_server_url.ReplaceComponents(replacements);

// Verify that the current URL is the suggested URL.

EXPECT_EQ(https_server_new_url.spec(),