third_party/WebKit/Source/core/fetch/FetchContext.h - Issue 1418003006: Simplify starting a navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FetchContext.h

Issue 1418003006: Simplify starting a navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/FetchContext.h

diff --git a/third_party/WebKit/Source/core/fetch/FetchContext.h b/third_party/WebKit/Source/core/fetch/FetchContext.h

index 22869f183ccb464d053f32eb0b0b1cd3ef6e6766..6c02737679151b3f701b34dba36874435e4fa99c 100644

--- a/third_party/WebKit/Source/core/fetch/FetchContext.h

+++ b/third_party/WebKit/Source/core/fetch/FetchContext.h

@@ -83,7 +83,7 @@ public:

virtual void dispatchDidFail(unsigned long identifier, const ResourceError&, bool isInternalRequest);

virtual bool shouldLoadNewResource(Resource::Type) const { return false; }

- virtual void willStartLoadingResource(ResourceRequest&);

+ virtual void willStartLoadingResource(ResourceRequest&, bool isMainResource);

jochen (gone - plz use gerrit) 2015/11/06 05:28:05 enum would be nicer than bool

Nate Chapin 2015/11/06 17:42:55 Done.

virtual void didLoadResource();

virtual void addResourceTiming(const ResourceTimingInfo&);