Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/core/css/StyleRule.cpp

Issue 14178009: Remove CSS_REGIONS compile flag from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use RuntimeEnabledFeatures::cssRegionsEnabled all over the places. Guard WEBKIT_REGION_RULE at runt… Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/StyleRule.cpp
diff --git a/Source/core/css/StyleRule.cpp b/Source/core/css/StyleRule.cpp
index f4e0f5832bf946b7f0ff80f4bcf48bf3f251bba0..6ad34244692d777be1fd8ede49ed1b61cd9db35f 100644
--- a/Source/core/css/StyleRule.cpp
+++ b/Source/core/css/StyleRule.cpp
@@ -74,11 +74,9 @@ void StyleRuleBase::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
case Media:
static_cast<const StyleRuleMedia*>(this)->reportDescendantMemoryUsage(memoryObjectInfo);
return;
-#if ENABLE(CSS_REGIONS)
case Region:
static_cast<const StyleRuleRegion*>(this)->reportDescendantMemoryUsage(memoryObjectInfo);
return;
-#endif
case Import:
static_cast<const StyleRuleImport*>(this)->reportDescendantMemoryUsage(memoryObjectInfo);
return;
@@ -100,9 +98,6 @@ void StyleRuleBase::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
case Unknown:
case Charset:
case Keyframe:
-#if !ENABLE(CSS_REGIONS)
- case Region:
-#endif
ASSERT_NOT_REACHED();
return;
}
@@ -127,11 +122,9 @@ void StyleRuleBase::destroy()
case Supports:
delete static_cast<StyleRuleSupports*>(this);
return;
-#if ENABLE(CSS_REGIONS)
case Region:
delete static_cast<StyleRuleRegion*>(this);
return;
-#endif
case Import:
delete static_cast<StyleRuleImport*>(this);
return;
@@ -152,9 +145,6 @@ void StyleRuleBase::destroy()
case Unknown:
case Charset:
case Keyframe:
-#if !ENABLE(CSS_REGIONS)
- case Region:
-#endif
ASSERT_NOT_REACHED();
return;
}
@@ -174,10 +164,8 @@ PassRefPtr<StyleRuleBase> StyleRuleBase::copy() const
return static_cast<const StyleRuleMedia*>(this)->copy();
case Supports:
return static_cast<const StyleRuleSupports*>(this)->copy();
-#if ENABLE(CSS_REGIONS)
case Region:
return static_cast<const StyleRuleRegion*>(this)->copy();
-#endif
case Import:
// FIXME: Copy import rules.
ASSERT_NOT_REACHED();
@@ -195,9 +183,6 @@ PassRefPtr<StyleRuleBase> StyleRuleBase::copy() const
case Unknown:
case Charset:
case Keyframe:
-#if !ENABLE(CSS_REGIONS)
- case Region:
-#endif
ASSERT_NOT_REACHED();
return 0;
}
@@ -225,11 +210,9 @@ PassRefPtr<CSSRule> StyleRuleBase::createCSSOMWrapper(CSSStyleSheet* parentSheet
case Supports:
rule = CSSSupportsRule::create(static_cast<StyleRuleSupports*>(self), parentSheet);
break;
-#if ENABLE(CSS_REGIONS)
case Region:
rule = WebKitCSSRegionRule::create(static_cast<StyleRuleRegion*>(self), parentSheet);
eseidel 2013/04/30 00:11:09 The constructor for WebKitCSSRegionRule should lik
break;
-#endif
case Import:
rule = CSSImportRule::create(static_cast<StyleRuleImport*>(self), parentSheet);
break;
@@ -250,9 +233,6 @@ PassRefPtr<CSSRule> StyleRuleBase::createCSSOMWrapper(CSSStyleSheet* parentSheet
case Unknown:
case Charset:
case Keyframe:
-#if !ENABLE(CSS_REGIONS)
- case Region:
-#endif
ASSERT_NOT_REACHED();
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698