Source/core/css/StyleResolver.cpp - Issue 14178009: Remove CSS_REGIONS compile flag from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StyleResolver.cpp

Issue 14178009: Remove CSS_REGIONS compile flag from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use RuntimeEnabledFeatures::cssRegionsEnabled all over the places. Guard WEBKIT_REGION_RULE at runt… Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/StyleResolver.cpp

diff --git a/Source/core/css/StyleResolver.cpp b/Source/core/css/StyleResolver.cpp

index dc79d92d42da0a7c24202d32d3ccf175c2842abd..e1373f273f8876375eec777126e83b58f7353123 100644

--- a/Source/core/css/StyleResolver.cpp

+++ b/Source/core/css/StyleResolver.cpp

@@ -3194,10 +3194,8 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)

case CSSPropertyWebkitFlexWrap:

case CSSPropertyWebkitJustifyContent:

case CSSPropertyWebkitOrder:

-#if ENABLE(CSS_REGIONS)

case CSSPropertyWebkitFlowFrom:

case CSSPropertyWebkitFlowInto:

-#endif

case CSSPropertyWebkitFontKerning:

case CSSPropertyWebkitFontSmoothing:

case CSSPropertyWebkitFontVariantLigatures:

@@ -3236,12 +3234,10 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)

case CSSPropertyWebkitPerspectiveOriginX:

case CSSPropertyWebkitPerspectiveOriginY:

case CSSPropertyWebkitPrintColorAdjust:

-#if ENABLE(CSS_REGIONS)

case CSSPropertyWebkitRegionBreakAfter:

eseidel 2013/04/30 00:11:09 Does StyleResolver::applyProperty check (or ASSERT

case CSSPropertyWebkitRegionBreakBefore:

case CSSPropertyWebkitRegionBreakInside:

case CSSPropertyWebkitRegionOverflow:

-#endif

case CSSPropertyWebkitRtlOrdering:

case CSSPropertyWebkitRubyPosition:

case CSSPropertyWebkitTextCombine: