Issue 1417713008: Remove const std::string return by std::string

Issue 1417713008: Remove const std::string return by std::string (Closed)

Created:
5 years, 1 month ago by tanay.c

Modified:
5 years, 1 month ago

Reviewers:
stevenjb

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove const std::string return by std::string BUG=393155 Committed: https://crrev.com/10e6d0158e3db71b47d0bedd977a75084deee836 Cr-Commit-Position: refs/heads/master@{#359054}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	chrome/browser/chromeos/options/vpn_config_view.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download
	M	chrome/browser/chromeos/options/vpn_config_view.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417713008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417713008/1

5 years, 1 month ago (2015-11-11 04:17:26 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/10e6d0158e3db71b47d0bedd977a75084deee836 Cr-Commit-Position: refs/heads/master@{#359054}

5 years, 1 month ago (2015-11-11 04:40:45 UTC) #7

vabr (Chromium)

5 years, 1 month ago (2015-11-11 09:20:56 UTC) #8

Message was sent while issue was closed.

Drive-by: Please consider http://crbug.com/393155#c4 in the future, dropping the
const might actually not make things better.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages