Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/chromeos/options/vpn_config_view.h

Issue 1417713008: Remove const std::string return by std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/options/vpn_config_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_OPTIONS_VPN_CONFIG_VIEW_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_OPTIONS_VPN_CONFIG_VIEW_H_
6 #define CHROME_BROWSER_CHROMEOS_OPTIONS_VPN_CONFIG_VIEW_H_ 6 #define CHROME_BROWSER_CHROMEOS_OPTIONS_VPN_CONFIG_VIEW_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 110
111 // Get text from input field. 111 // Get text from input field.
112 const std::string GetTextFromField(views::Textfield* textfield, 112 const std::string GetTextFromField(views::Textfield* textfield,
113 bool trim_whitespace) const; 113 bool trim_whitespace) const;
114 114
115 // Get passphrase from input field. 115 // Get passphrase from input field.
116 const std::string GetPassphraseFromField( 116 const std::string GetPassphraseFromField(
117 PassphraseTextfield* textfield) const; 117 PassphraseTextfield* textfield) const;
118 118
119 // Convenience methods to get text from input field or cached VirtualNetwork. 119 // Convenience methods to get text from input field or cached VirtualNetwork.
120 const std::string GetService() const; 120 std::string GetService() const;
121 const std::string GetServer() const; 121 std::string GetServer() const;
122 const std::string GetPSKPassphrase() const; 122 std::string GetPSKPassphrase() const;
123 const std::string GetUsername() const; 123 std::string GetUsername() const;
124 const std::string GetUserPassphrase() const; 124 std::string GetUserPassphrase() const;
125 const std::string GetOTP() const; 125 std::string GetOTP() const;
126 const std::string GetGroupName() const; 126 std::string GetGroupName() const;
127 const std::string GetServerCACertPEM() const; 127 std::string GetServerCACertPEM() const;
128 bool GetSaveCredentials() const; 128 bool GetSaveCredentials() const;
129 int GetProviderTypeIndex() const; 129 int GetProviderTypeIndex() const;
130 std::string GetProviderTypeString() const; 130 std::string GetProviderTypeString() const;
131 131
132 // Parses a VPN UI |property| from the given |network|. |key| is the property 132 // Parses a VPN UI |property| from the given |network|. |key| is the property
133 // name within the type-specific VPN subdictionary named |dict_key|. 133 // name within the type-specific VPN subdictionary named |dict_key|.
134 void ParseVPNUIProperty(const NetworkState* network, 134 void ParseVPNUIProperty(const NetworkState* network,
135 const std::string& dict_key, 135 const std::string& dict_key,
136 const std::string& key, 136 const std::string& key,
137 NetworkPropertyUIData* property_ui_data); 137 NetworkPropertyUIData* property_ui_data);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 std::string client_cert_id_; 189 std::string client_cert_id_;
190 190
191 base::WeakPtrFactory<VPNConfigView> weak_ptr_factory_; 191 base::WeakPtrFactory<VPNConfigView> weak_ptr_factory_;
192 192
193 DISALLOW_COPY_AND_ASSIGN(VPNConfigView); 193 DISALLOW_COPY_AND_ASSIGN(VPNConfigView);
194 }; 194 };
195 195
196 } // namespace chromeos 196 } // namespace chromeos
197 197
198 #endif // CHROME_BROWSER_CHROMEOS_OPTIONS_VPN_CONFIG_VIEW_H_ 198 #endif // CHROME_BROWSER_CHROMEOS_OPTIONS_VPN_CONFIG_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/options/vpn_config_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698