Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1417673009: base: SysInfo::Uptime() returns a TimeDelta (Closed)

Created:
5 years, 1 month ago by Simon Que
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, oshima+watch_chromium.org, davemoore+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: SysInfo::Uptime() returns a TimeDelta This makes more sense than returning a number of milliseconds, especially when the function name does not reflect the return value type. In a few places, the number of milliseconds is converted into a TimeDelta anyway. So this patch simplifies some of the code out there. BUG=chromium:157549 TEST=build successfully, SysInfoTest passes TBR=jif@chromium.org Signed-off-by: Simon Que <sque@chromium.org>; Committed: https://crrev.com/0f78ba540eb43fb2bb3b7726eeb41d22bfee09a3 Cr-Commit-Position: refs/heads/master@{#357937}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Change Uptime usage in iOS code #

Patch Set 4 : Update perf_provider_chromeos.cc (just updated in another CL) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M base/sys_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sys_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sys_info_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/caps/generate_state_json.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/perf/perf_provider_chromeos.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_ios.mm View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/power_usage_monitor_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
Simon Que
Notes for getting LGTMs from individual owners: chrome/browser/ui: sky, pkasting chrome/browser: isherman, asvitkine content: jam, ...
5 years, 1 month ago (2015-11-04 00:46:49 UTC) #2
Nico
lgtm!
5 years, 1 month ago (2015-11-04 00:59:39 UTC) #3
Nico
On 2015/11/04 00:59:39, Nico wrote: > lgtm! (sky, pkasting: I looked at the chrome/ files ...
5 years, 1 month ago (2015-11-04 01:00:20 UTC) #4
Mark Mentovai
LGTM
5 years, 1 month ago (2015-11-04 01:16:00 UTC) #5
Simon Que
+jochen +jam for contents/ +jochen +blundell for components/
5 years, 1 month ago (2015-11-04 01:46:14 UTC) #7
blundell
lgtm
5 years, 1 month ago (2015-11-04 10:06:07 UTC) #8
jam
lgtm
5 years, 1 month ago (2015-11-04 18:32:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417673009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417673009/1
5 years, 1 month ago (2015-11-04 20:05:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/90109) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-04 20:09:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417673009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417673009/20001
5 years, 1 month ago (2015-11-04 21:37:23 UTC) #16
Simon Que
+jif for components/open_from_clipboard/clipboard_recent_content_ios.mm
5 years, 1 month ago (2015-11-04 21:51:30 UTC) #18
Nico
Feel free to tbr this, for mechanical changes with general approval that's OK On Nov ...
5 years, 1 month ago (2015-11-04 22:09:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417673009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417673009/60001
5 years, 1 month ago (2015-11-04 22:42:01 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-05 00:01:13 UTC) #24
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0f78ba540eb43fb2bb3b7726eeb41d22bfee09a3 Cr-Commit-Position: refs/heads/master@{#357937}
5 years, 1 month ago (2015-11-05 00:01:58 UTC) #25
jif-google
5 years, 1 month ago (2015-11-05 09:46:42 UTC) #28
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698