chrome/browser/metrics/perf/perf_provider_chromeos.cc - Issue 1417673009: base: SysInfo::Uptime() returns a TimeDelta

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/perf/perf_provider_chromeos.cc

Issue 1417673009: base: SysInfo::Uptime() returns a TimeDelta (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update perf_provider_chromeos.cc (just updated in another CL) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/perf/perf_provider_chromeos.cc

diff --git a/chrome/browser/metrics/perf/perf_provider_chromeos.cc b/chrome/browser/metrics/perf/perf_provider_chromeos.cc

index 2d2a47020f86f6e18cb548461738e4d4db427873..c466eee9cf7a2dde3c5039496eabad424cd8dc55 100644

--- a/chrome/browser/metrics/perf/perf_provider_chromeos.cc

+++ b/chrome/browser/metrics/perf/perf_provider_chromeos.cc

@@ -407,7 +407,8 @@ void PerfProvider::ParseOutputProtoIfValid(

AddToPerfHistogram(PROTOBUF_NOT_PARSED);

return;

}

- sampled_profile->set_ms_after_boot(base::SysInfo::Uptime());

+ sampled_profile->set_ms_after_boot(

+ base::SysInfo::Uptime().InMilliseconds());

sampled_profile->mutable_perf_data()->Swap(&perf_data_proto);

} else {

DCHECK(!perf_stat.empty());