Issue 1417583007: Merge to XFA: Use static_cast for various CPDF_Object conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417583007: Merge to XFA: Use static_cast for various CPDF_Object conversions. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Use static_cast for various CPDF_Object conversions. This Cl converts a bunch of c-style casts to static_cast<CPDF_Object*>(). BUG=pdfium:201 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1428583003 . (cherry picked from commit 74b147b5747cf65a8936d201b3ed5b32454365cc) Committed: https://pdfium.googlesource.com/pdfium/+/d43ebdd78a854ebdaa7de301321ef8e698541bd6

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -132 lines)			Patch
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View	10 chunks	+52 lines, -72 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	14 chunks	+34 lines, -56 lines	0 comments	Download
M	core/src/fpdfdoc/doc_form.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

dsinclair

5 years, 1 month ago (2015-10-27 19:37:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d43ebdd78a854ebdaa7de301321ef8e698541bd6 (presubmit successful).