Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1428583003: Use static_cast for various CPDF_Object conversions. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use static_cast for various CPDF_Object conversions. This Cl converts a bunch of c-style casts to static_cast<CPDF_Object*>(). BUG=pdfium:201 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/74b147b5747cf65a8936d201b3ed5b32454365cc

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -132 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 10 chunks +52 lines, -72 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 14 chunks +34 lines, -56 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
PTAL.
5 years, 1 month ago (2015-10-27 19:28:08 UTC) #2
Tom Sepez
lgtm
5 years, 1 month ago (2015-10-27 19:31:35 UTC) #3
dsinclair
5 years, 1 month ago (2015-10-27 19:32:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
74b147b5747cf65a8936d201b3ed5b32454365cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698