Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1417563005: [Extensions] Migrate ServiceWorker off behavior feature system (Closed)

Created:
5 years, 1 month ago by Devlin
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Migrate ServiceWorker off behavior feature system The FeatureSystem is failing to retrieve the behavior feature for service workers, but the only reason this seems to be the case is because of potential corruption in the JSON files (or the JSON parser otherwise choking). For now, to reduce the crash rates, just migrate the service worker restriction off the behavior feature system. BUG=461915 Committed: https://crrev.com/2507a2fcd25244dadb7dfcc316426bee7b1df275 Cr-Commit-Position: refs/heads/master@{#356123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Devlin
5 years, 1 month ago (2015-10-26 20:00:36 UTC) #2
Ken Rockot(use gerrit already)
that's... odd. LGTM
5 years, 1 month ago (2015-10-26 20:02:59 UTC) #3
Devlin
On 2015/10/26 20:02:59, Ken Rockot wrote: > that's... odd. LGTM Agreed. But I've come up ...
5 years, 1 month ago (2015-10-26 20:29:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417563005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417563005/1
5 years, 1 month ago (2015-10-26 20:29:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 21:15:20 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2507a2fcd25244dadb7dfcc316426bee7b1df275 Cr-Commit-Position: refs/heads/master@{#356123}
5 years, 1 month ago (2015-10-26 21:16:18 UTC) #8
anthonyvd
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1412683007/ by anthonyvd@chromium.org. ...
5 years, 1 month ago (2015-10-26 21:50:39 UTC) #9
Devlin
5 years, 1 month ago (2015-10-26 22:11:08 UTC) #10
Message was sent while issue was closed.
On 2015/10/26 21:50:39, anthonyvd wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1412683007/ by mailto:anthonyvd@chromium.org.
> 
> The reason for reverting is: Reverting because this CL appears to be causing
> failures on this bot:
>
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...
> ..

To me, that failure looks like a flake, and it seems like the subsequent build
succeeded compilation?

https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...

Powered by Google App Engine
This is Rietveld 408576698