Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1412683007: Revert of [Extensions] Migrate ServiceWorker off behavior feature system (Closed)

Created:
5 years, 1 month ago by anthonyvd
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Migrate ServiceWorker off behavior feature system (patchset #1 id:1 of https://codereview.chromium.org/1417563005/ ) Reason for revert: Reverting because this CL appears to be causing failures on this bot: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/14499 . Original issue's description: > [Extensions] Migrate ServiceWorker off behavior feature system > > The FeatureSystem is failing to retrieve the behavior feature for service > workers, but the only reason this seems to be the case is because of > potential corruption in the JSON files (or the JSON parser otherwise choking). > For now, to reduce the crash rates, just migrate the service worker restriction > off the behavior feature system. > > BUG=461915 > > Committed: https://crrev.com/2507a2fcd25244dadb7dfcc316426bee7b1df275 > Cr-Commit-Position: refs/heads/master@{#356123} TBR=rockot@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461915 Committed: https://crrev.com/5708524cd0517ad825093d8cb4e9171ca99b3f42 Cr-Commit-Position: refs/heads/master@{#356137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 2 chunks +1 line, -7 lines 0 comments Download
M extensions/renderer/dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
anthonyvd
Created Revert of [Extensions] Migrate ServiceWorker off behavior feature system
5 years, 1 month ago (2015-10-26 21:50:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412683007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412683007/1
5 years, 1 month ago (2015-10-26 21:52:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 21:55:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5708524cd0517ad825093d8cb4e9171ca99b3f42 Cr-Commit-Position: refs/heads/master@{#356137}
5 years, 1 month ago (2015-10-26 21:57:28 UTC) #4
Devlin
On 2015/10/26 21:57:28, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 1 month ago (2015-10-26 22:11:42 UTC) #5
Devlin
5 years, 1 month ago (2015-10-26 22:24:38 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1406083004/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Talked to Anthony offline and we agreed the error
was probably not my CL..

Powered by Google App Engine
This is Rietveld 408576698