Move implementation of dart:mojo.internal to mojo/public/platform/dart

Move implementation of dart:mojo.internal to mojo/public/platform/dart

BUG=
R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/517284289fa793c21a772a53e2ed04fc34273e1e

[Cutch, 2015-10-28 16:34:27]

Description was changed from

==========
Move implementation of dart:mojo.internal to mojo/public/platform/dart

BUG=
==========

to

==========
Move implementation of dart:mojo.internal to mojo/public/platform/dart

BUG=
==========

[Cutch, 2015-10-28 16:34:27]

johnmccutchan@google.com changed reviewers:
+ abarth@chromium.org, jamesr@chromium.org

[Cutch, 2015-10-28 16:34:59]

Not for submit because of our dependency on //dart.

PTAL

[Cutch, 2015-10-28 21:29:24]

PTAL at Patch Set 3.

https://codereview.chromium.org/1417523003/diff/40001/mojo/public/platform/da...
File mojo/public/platform/dart/BUILD.gn (right):

https://codereview.chromium.org/1417523003/diff/40001/mojo/public/platform/da...
mojo/public/platform/dart/BUILD.gn:14: "dart/runtime:libdart",
This somehow passes both gn check and the presubmit script.

[jamesr, 2015-10-28 21:43:19]

https://codereview.chromium.org/1417523003/diff/60001/mojo/public/platform/da...
File mojo/public/platform/dart/BUILD.gn (right):

https://codereview.chromium.org/1417523003/diff/60001/mojo/public/platform/da...
mojo/public/platform/dart/BUILD.gn:14: "dart/runtime:libdart",
NAK, the script is dumb but this is just as fragile in practice.  please fix the
script and user a proper path. if we want to make this configurable we should do
that with a documented gni file

[Cutch, 2015-10-28 21:56:41]

On 2015/10/28 21:43:19, jamesr wrote:
>
https://codereview.chromium.org/1417523003/diff/60001/mojo/public/platform/da...
> File mojo/public/platform/dart/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1417523003/diff/60001/mojo/public/platform/da...
> mojo/public/platform/dart/BUILD.gn:14: "dart/runtime:libdart",
> NAK, the script is dumb but this is just as fragile in practice.  please fix
the
> script and user a proper path. if we want to make this configurable we should
do
> that with a documented gni file

Patch Set 5 uses an absolute path and I've put hacks into mojo_sdk.gni and
PRESUBMIT.py to allow for it.

[jamesr, 2015-10-28 22:17:11]

https://codereview.chromium.org/1417523003/diff/80001/mojo/PRESUBMIT.py
File mojo/PRESUBMIT.py (right):

https://codereview.chromium.org/1417523003/diff/80001/mojo/PRESUBMIT.py#newco...
mojo/PRESUBMIT.py:20: "//dart/runtime:libdart"],
this allows anything in the SDK to reference this, which isn't what you want.
instead in _FindIllegalAbsolutePathsInBuildFiles check that if
//dart/runtime:libdart is set the build file being checked is in
//mojo/public/platform/dart

https://codereview.chromium.org/1417523003/diff/80001/mojo/public/platform/da...
File mojo/public/platform/dart/README.md (right):

https://codereview.chromium.org/1417523003/diff/80001/mojo/public/platform/da...
mojo/public/platform/dart/README.md:11: under //dart.
we should provide some guidance about which dart SDK works with this code

[Cutch, 2015-10-28 22:32:09]

https://codereview.chromium.org/1417523003/diff/80001/mojo/PRESUBMIT.py
File mojo/PRESUBMIT.py (right):

https://codereview.chromium.org/1417523003/diff/80001/mojo/PRESUBMIT.py#newco...
mojo/PRESUBMIT.py:20: "//dart/runtime:libdart"],
On 2015/10/28 22:17:11, jamesr wrote:
> this allows anything in the SDK to reference this, which isn't what you want.
> instead in _FindIllegalAbsolutePathsInBuildFiles check that if
> //dart/runtime:libdart is set the build file being checked is in
> //mojo/public/platform/dart

Done.

https://codereview.chromium.org/1417523003/diff/80001/mojo/public/platform/da...
File mojo/public/platform/dart/README.md (right):

https://codereview.chromium.org/1417523003/diff/80001/mojo/public/platform/da...
mojo/public/platform/dart/README.md:11: under //dart.
On 2015/10/28 22:17:11, jamesr wrote:
> we should provide some guidance about which dart SDK works with this code

Done.

[jamesr, 2015-10-28 22:41:23]

lgtm

[Cutch, 2015-10-29 14:13:41]

Committed patchset #8 (id:140001) manually as
517284289fa793c21a772a53e2ed04fc34273e1e (presubmit successful).