Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Presubmit script for mojo | 5 """Presubmit script for mojo |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| 11 import os.path | 11 import os.path |
| 12 import re | 12 import re |
| 13 | 13 |
| 14 # NOTE: The EDK allows all external paths, so doesn't need a whitelist. | 14 # NOTE: The EDK allows all external paths, so doesn't need a whitelist. |
| 15 _PACKAGE_WHITELISTED_EXTERNAL_PATHS = { | 15 _PACKAGE_WHITELISTED_EXTERNAL_PATHS = { |
| 16 "SDK": ["//build/module_args/mojo.gni", | 16 "SDK": ["//build/module_args/mojo.gni", |
| 17 "//build/module_args/dart.gni", | 17 "//build/module_args/dart.gni", |
| 18 "//testing/gtest", | 18 "//testing/gtest", |
| 19 "//third_party/cython"], | 19 "//third_party/cython", |
| 20 "//dart/runtime:libdart"], | |
|
jamesr
2015/10/28 22:17:11
this allows anything in the SDK to reference this,
Cutch
2015/10/28 22:32:09
Done.
| |
| 20 "services": ["//build/module_args/mojo.gni", | 21 "services": ["//build/module_args/mojo.gni", |
| 21 "//testing/gtest"], | 22 "//testing/gtest"], |
| 22 } | 23 } |
| 23 | 24 |
| 24 # These files are not part of the exported package. | 25 # These files are not part of the exported package. |
| 25 _PACKAGE_IGNORED_BUILD_FILES = { | 26 _PACKAGE_IGNORED_BUILD_FILES = { |
| 26 "SDK": {}, | 27 "SDK": {}, |
| 27 "EDK": {}, | 28 "EDK": {}, |
| 28 "services": {"mojo/services/BUILD.gn", "mojo/services/mojo_services.gni"}, | 29 "services": {"mojo/services/BUILD.gn", "mojo/services/mojo_services.gni"}, |
| 29 } | 30 } |
| (...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 280 def CheckChangeOnUpload(input_api, output_api): | 281 def CheckChangeOnUpload(input_api, output_api): |
| 281 results = [] | 282 results = [] |
| 282 results.extend(_CommonChecks(input_api, output_api)) | 283 results.extend(_CommonChecks(input_api, output_api)) |
| 283 results.extend(_CheckChangePylintsClean(input_api, output_api)) | 284 results.extend(_CheckChangePylintsClean(input_api, output_api)) |
| 284 return results | 285 return results |
| 285 | 286 |
| 286 def CheckChangeOnCommit(input_api, output_api): | 287 def CheckChangeOnCommit(input_api, output_api): |
| 287 results = [] | 288 results = [] |
| 288 results.extend(_CommonChecks(input_api, output_api)) | 289 results.extend(_CommonChecks(input_api, output_api)) |
| 289 return results | 290 return results |
| OLD | NEW |