SVG Web Animations: Add SVGIntegerOptionalIntegerInterpolationType

SVG Web Animations: Add SVGIntegerOptionalIntegerInterpolationType

This change adds SVGIntegerOptionalIntegerInterpolationType for the
order attribute, replacing the legacy pipeline that used
IntegerOptionalIntegerSVGInterpolation.

BUG=530436

[sashab, 2015-11-03 03:25:06]

Description was changed from

==========
SVG Web Animations: Add SVGIntegerOptionalIntegerInterpolationType

This change adds SVGIntegerOptionalIntegerInterpolationType for the
order attribute.

BUG=530436
==========

to

==========
SVG Web Animations: Add SVGIntegerOptionalIntegerInterpolationType

This change adds SVGIntegerOptionalIntegerInterpolationType for the
order attribute, replacing the legacy pipeline that used
IntegerOptionalIntegerSVGInterpolation.

BUG=530436
==========

[sashab, 2015-11-03 03:25:20]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2015-11-03 04:08:12]

lgtm with nits.

https://codereview.chromium.org/1417483015/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp
(right):

https://codereview.chromium.org/1417483015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp:18:
// For filterRes, negative values are an error. Zero values disable rendering of
the element which referenced the filter.
I don't think we need this comment.
Looks like filterRes is obsolete:
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/filterRes

https://codereview.chromium.org/1417483015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp:19:
PassRefPtrWillBeRawPtr<SVGInteger> toPositiveInteger(const InterpolableValue*
number, int min)
No need for min parameter if it's always 1.

[sashab, 2015-11-03 04:15:59]

https://codereview.chromium.org/1417483015/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp
(right):

https://codereview.chromium.org/1417483015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp:18:
// For filterRes, negative values are an error. Zero values disable rendering of
the element which referenced the filter.
On 2015/11/03 04:08:12, alancutter wrote:
> I don't think we need this comment.
> Looks like filterRes is obsolete:
> https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/filterRes

Done.

https://codereview.chromium.org/1417483015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp:19:
PassRefPtrWillBeRawPtr<SVGInteger> toPositiveInteger(const InterpolableValue*
number, int min)
On 2015/11/03 04:08:11, alancutter wrote:
> No need for min parameter if it's always 1.

Done.

[sashab, 2015-11-03 04:16:15]

The CQ bit was checked by sashab@chromium.org

[sashab, 2015-11-03 04:16:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1417483015/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-03 04:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417483015/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417483015/40001

[commit-bot: I haz the power, 2015-11-03 04:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 04:24:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2015-11-03 04:41:47]

sashab@chromium.org changed reviewers:
+ dstockwell@chromium.org

[sashab, 2015-11-03 04:41:47]

dstockwell please review files in svg/

[pdr., 2015-11-03 21:19:10]

On 2015/11/03 at 04:41:47, sashab wrote:
> dstockwell please review files in svg/

svg/ LGTM. If this lands after https://codereview.chromium.org/1412123015,
please do update it to use the new pattern.