Issue 1417483006: Support for searching files by import/export/part URIs and library identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417483006: Support for searching files by import/export/part URIs and library identifiers. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Support for searching files by import/export/part URIs and library identifiers. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c7907e780079a475b087f6bc614fd0967d3ea4a7

Patch Set 1 #

Total comments: 2

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+258 lines, -27 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	pkg/analysis_server/lib/src/search/search_domain.dart	View	6 chunks	+72 lines, -12 lines	1 comment	Download
M	pkg/analysis_server/test/analysis_abstract.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/search/abstract_search_domain.dart	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/search/element_references_test.dart	View	3 chunks	+173 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1417483006/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1417483006/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode577 pkg/analysis_server/lib/src/analysis_server.dart:577: // is a mistake. Remove this from ElementLocator. ...

5 years, 2 months ago (2015-10-20 14:57:15 UTC) #2

scheglov

5 years, 2 months ago (2015-10-20 15:52:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c7907e780079a475b087f6bc614fd0967d3ea4a7 (presubmit successful).

Expand Messages | Collapse Messages